src/heap/heap.cc - Issue 997423002: Use the incremental root marking visitor for overapproximating the weak closure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 997423002: Use the incremental root marking visitor for overapproximating the weak closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index e0dd8b63b2dd0ea3f073aff50f896110d7fcae9c..913ac13d43832494e2234c123e6e421e2074cc6e 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -776,9 +776,7 @@ void Heap::OverApproximateWeakClosure(const char* gc_reason) {

CallGCPrologueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags);

}

- mark_compact_collector()->OverApproximateWeakClosure();

- incremental_marking()->set_should_hurry(false);

- incremental_marking()->set_weak_closure_was_overapproximated(true);

+ incremental_marking()->MarkObjectGroups();

{

GCCallbacksScope scope(this);

if (scope.CheckReenter()) {

« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | no next file with comments »