Use the incremental root marking visitor for overapproximating the weak closure

src/heap/mark-compact.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/base/atomicops.h"
 #include "src/base/bits.h"
 #include "src/code-stubs.h"
 #include "src/compilation-cache.h"
@@ skipping 2210 matching lines @@
     CHECK(success);
     marking_deque_memory_committed_ = false;
   }
 }
 
 
 void MarkCompactCollector::OverApproximateWeakClosure() {
   GCTracer::Scope gc_scope(heap()->tracer(),
                            GCTracer::Scope::MC_INCREMENTAL_WEAKCLOSURE);
 
-  RootMarkingVisitor root_visitor(heap());
+  ObjectVisitor* root_visitor =
+      heap()->incremental_marking()->CreateRootMarkingVisitor();

[Hannes Payer (out of office), 2015/03/12 12:28:48]

Instead of allocating the incremental root marking visitor and deallocating it
later (and leaking it to a different context), why don't you create a method in
incremental marking that incrementally marks the object groups with a stack
allocated visitor?

Hmm, wait, it feels like this method should be part of incremental marking. Can
we move it there?

   isolate()->global_handles()->IterateObjectGroups(
-      &root_visitor, &IsUnmarkedHeapObjectWithHeap);
+      root_visitor, &IsUnmarkedHeapObjectWithHeap);
+  delete root_visitor;
+
   MarkImplicitRefGroups();
 
   // Remove object groups after marking phase.
   heap()->isolate()->global_handles()->RemoveObjectGroups();
   heap()->isolate()->global_handles()->RemoveImplicitRefGroups();
 }
 
 
 void MarkCompactCollector::MarkLiveObjects() {
   GCTracer::Scope gc_scope(heap()->tracer(), GCTracer::Scope::MC_MARK);
@@ skipping 2412 matching lines @@
   SlotsBuffer* buffer = *buffer_address;
   while (buffer != NULL) {
     SlotsBuffer* next_buffer = buffer->next();
     DeallocateBuffer(buffer);
     buffer = next_buffer;
   }
   *buffer_address = NULL;
 }
 }
 }  // namespace v8::internal