Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: src/heap/heap.cc

Issue 997423002: Use the incremental root marking visitor for overapproximating the weak closure (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | src/heap/mark-compact.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/base/once.h" 10 #include "src/base/once.h"
(...skipping 759 matching lines...) Expand 10 before | Expand all | Expand 10 after
770 GCCallbacksScope scope(this); 770 GCCallbacksScope scope(this);
771 if (scope.CheckReenter()) { 771 if (scope.CheckReenter()) {
772 AllowHeapAllocation allow_allocation; 772 AllowHeapAllocation allow_allocation;
773 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL); 773 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);
774 VMState<EXTERNAL> state(isolate_); 774 VMState<EXTERNAL> state(isolate_);
775 HandleScope handle_scope(isolate_); 775 HandleScope handle_scope(isolate_);
776 CallGCPrologueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags); 776 CallGCPrologueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags);
777 } 777 }
778 } 778 }
779 mark_compact_collector()->OverApproximateWeakClosure(); 779 mark_compact_collector()->OverApproximateWeakClosure();
780 incremental_marking()->set_should_hurry(false);
781 incremental_marking()->set_weak_closure_was_overapproximated(true); 780 incremental_marking()->set_weak_closure_was_overapproximated(true);
782 { 781 {
783 GCCallbacksScope scope(this); 782 GCCallbacksScope scope(this);
784 if (scope.CheckReenter()) { 783 if (scope.CheckReenter()) {
785 AllowHeapAllocation allow_allocation; 784 AllowHeapAllocation allow_allocation;
786 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL); 785 GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);
787 VMState<EXTERNAL> state(isolate_); 786 VMState<EXTERNAL> state(isolate_);
788 HandleScope handle_scope(isolate_); 787 HandleScope handle_scope(isolate_);
789 CallGCEpilogueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags); 788 CallGCEpilogueCallbacks(kGCTypeMarkSweepCompact, kNoGCCallbackFlags);
790 } 789 }
(...skipping 5789 matching lines...) Expand 10 before | Expand all | Expand 10 after
6580 static_cast<int>(object_sizes_last_time_[index])); 6579 static_cast<int>(object_sizes_last_time_[index]));
6581 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT) 6580 CODE_AGE_LIST_COMPLETE(ADJUST_LAST_TIME_OBJECT_COUNT)
6582 #undef ADJUST_LAST_TIME_OBJECT_COUNT 6581 #undef ADJUST_LAST_TIME_OBJECT_COUNT
6583 6582
6584 MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_)); 6583 MemCopy(object_counts_last_time_, object_counts_, sizeof(object_counts_));
6585 MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_)); 6584 MemCopy(object_sizes_last_time_, object_sizes_, sizeof(object_sizes_));
6586 ClearObjectStats(); 6585 ClearObjectStats();
6587 } 6586 }
6588 } 6587 }
6589 } // namespace v8::internal 6588 } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/heap/incremental-marking.h » ('j') | src/heap/mark-compact.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698