Remove duplicated headers from modules/ directory

Remove duplicated headers from modules/ directory where the implementation file includes the same dependencies as the corresponding primary header. 

Remove the dependencies from headers where possible.

BUG=317231
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163907

[lgombos, 2013-12-09 00:44:32]

The win for the modules/ directory is obviously limited - perhaps the biggest
impact change is in IDBRequest.h under indexdb/.

[Nico, 2013-12-09 02:01:27]

see comment on the other cl

https://codereview.chromium.org/99733006/diff/1/Source/modules/donottrack/Nav...
File Source/modules/donottrack/NavigatorDoNotTrack.cpp (left):

https://codereview.chromium.org/99733006/diff/1/Source/modules/donottrack/Nav...
Source/modules/donottrack/NavigatorDoNotTrack.cpp:34: #include
"core/loader/FrameLoader.h"
There's a call to `loader().something` below, so I think this should probably
stay

https://codereview.chromium.org/99733006/diff/1/Source/modules/indexeddb/IDBC...
File Source/modules/indexeddb/IDBCursor.h (left):

https://codereview.chromium.org/99733006/diff/1/Source/modules/indexeddb/IDBC...
Source/modules/indexeddb/IDBCursor.h:33: #include
"modules/indexeddb/IDBTransaction.h"
Isn't this needed since there's a RefPtr<IDBTransaction> below (which requires
availability of AddRef of its template argument at instantiation time)?

https://codereview.chromium.org/99733006/diff/1/Source/modules/webdatabase/Da...
File Source/modules/webdatabase/DatabaseBackendBase.cpp (left):

https://codereview.chromium.org/99733006/diff/1/Source/modules/webdatabase/Da...
Source/modules/webdatabase/DatabaseBackendBase.cpp:43: #include
"platform/weborigin/SecurityOrigin.h"
The header includes this only conditionally:

#if !LOG_DISABLED || !ERROR_DISABLED
#include "platform/weborigin/SecurityOrigin.h"
#endif

[Inactive, 2013-12-10 20:26:19]

https://codereview.chromium.org/99733006/diff/1/Source/modules/indexeddb/IDBC...
File Source/modules/indexeddb/IDBCursor.h (left):

https://codereview.chromium.org/99733006/diff/1/Source/modules/indexeddb/IDBC...
Source/modules/indexeddb/IDBCursor.h:33: #include
"modules/indexeddb/IDBTransaction.h"
On 2013/12/09 02:01:27, Nico wrote:
> Isn't this needed since there's a RefPtr<IDBTransaction> below (which requires
> availability of AddRef of its template argument at instantiation time)?

AFAIK, a forward declaration is sufficient for T despite having a RefPtr<T>
member in the header, as long as that member is not used in the header.

If the ~IDBCursor() destructor were omitted, or if it was defined in the header
(not just declared), then the code would not build with a simple forward
declaration. However, in this case, the destructor is defined in the cpp and
IDBTransaction.h is included from the cpp so it should be fine.

[lgombos, 2013-12-14 01:03:08]

On 2013/12/10 20:26:19, Chris Dumez wrote:

Thoughts on this CL ? Yay or nay ?

[eseidel, 2013-12-14 01:21:17]

lgtm

Meh.

[commit-bot: I haz the power, 2013-12-14 01:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/99733006/1

[commit-bot: I haz the power, 2013-12-14 04:13:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/99733006/1

[commit-bot: I haz the power, 2013-12-14 05:06:20]

Change committed as 163907