Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Issue 99733003: Add monotonic time and target property to cc::AnimationDelegate notifications (Closed)

Created:
7 years ago by ajuma
Modified:
7 years ago
Reviewers:
Ian Vollick, jamesr
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add monotonic time and target property to cc::AnimationDelegate notifications This adds monotonic time and target property as arguments to cc::AnimationDelegate::NotifyAnimation{Started, Finished}. The existing wall clock time argument can be removed once Blink's legacy implementation of CSS animations and transitions is removed. The target property argument is needed so that Blink can distinguish between notifications for CSS animations/transitions and notifications for the scroll animations being added for the CSSOM View smooth scroll API. BUG=299945, 243871 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239554

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Use TimeTicks instead of double #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -33 lines) Patch
M cc/animation/animation_delegate.h View 1 2 1 chunk +13 lines, -2 lines 0 comments Download
M cc/animation/layer_animation_controller.cc View 1 2 3 4 chunks +12 lines, -4 lines 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 2 11 chunks +49 lines, -17 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.h View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M webkit/renderer/compositor_bindings/web_to_cc_animation_delegate_adapter.cc View 1 2 1 chunk +24 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ajuma
The Blink side of this is http://crrev.com/99333005 (the chromium side needs to land before the ...
7 years ago (2013-12-03 00:04:51 UTC) #1
Ian Vollick
On 2013/12/03 00:04:51, ajuma wrote: > The Blink side of this is http://crrev.com/99333005 (the chromium ...
7 years ago (2013-12-05 21:43:49 UTC) #2
ajuma
+jamesr for compositor_bindings/
7 years ago (2013-12-05 21:51:59 UTC) #3
jamesr
https://codereview.chromium.org/99733003/diff/1/cc/animation/animation_delegate.h File cc/animation/animation_delegate.h (right): https://codereview.chromium.org/99733003/diff/1/cc/animation/animation_delegate.h#newcode18 cc/animation/animation_delegate.h:18: double monotonic_time, please use base::TimeTicks for monotonic time values. ...
7 years ago (2013-12-05 22:01:39 UTC) #4
ajuma
PTAL. https://codereview.chromium.org/99733003/diff/1/cc/animation/animation_delegate.h File cc/animation/animation_delegate.h (right): https://codereview.chromium.org/99733003/diff/1/cc/animation/animation_delegate.h#newcode18 cc/animation/animation_delegate.h:18: double monotonic_time, On 2013/12/05 22:01:39, jamesr wrote: > ...
7 years ago (2013-12-06 00:41:34 UTC) #5
ajuma
jamesr, PTAL.
7 years ago (2013-12-09 18:22:52 UTC) #6
jamesr
lgtm
7 years ago (2013-12-09 18:29:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajuma@chromium.org/99733003/60001
7 years ago (2013-12-09 18:36:27 UTC) #8
commit-bot: I haz the power
7 years ago (2013-12-09 21:30:28 UTC) #9
Message was sent while issue was closed.
Change committed as 239554

Powered by Google App Engine
This is Rietveld 408576698