Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 99733002: Update HTTPHeaderMap wrappers to use AtomicString type for header values (Closed)

Created:
7 years ago by Inactive
Modified:
7 years ago
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, gavinp+loader_chromium.org, alph+blink_chromium.org, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, abarth-chromium, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, devtools-reviews_chromium.org, arv+blink, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Update HTTPHeaderMap wrappers to use AtomicString type for header values Update HTTPHeaderMap wrappers to use AtomicString type for header values instead of String, for consistency with HTTPHeaderMap. This avoids uselessly constructing Strings and then having to convert it to an AtomicString, which has a cost. A lot of callers already have an AtomicString or a string literal, so we end up constructing AtomicStrings from Strings a lot less. HTTPHeaderMap uses AtomicString type for both header names and values to save memory, as there are a lot of identical strings. R=abarth, eseidel BUG=323739 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163027

Patch Set 1 #

Patch Set 2 : Rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -148 lines) Patch
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/CSSStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CrossOriginAccessControl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/CrossOriginAccessControl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ScriptResource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/history/HistoryItem.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/history/HistoryItem.cpp View 6 chunks +7 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/NetworkResourcesData.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/NetworkResourcesData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 6 chunks +13 lines, -13 lines 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 12 chunks +21 lines, -22 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.h View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/modules/websockets/WebSocketHandshake.cpp View 1 3 chunks +11 lines, -11 lines 0 comments Download
M Source/platform/network/HTTPHeaderMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/HTTPHeaderMap.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/network/HTTPParsers.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/network/HTTPParsers.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/network/HTTPRequest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/network/HTTPRequest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/ResourceRequest.h View 2 chunks +18 lines, -18 lines 0 comments Download
M Source/platform/network/ResourceRequest.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/network/ResourceResponse.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/network/ResourceResponse.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/network/WebSocketHandshakeResponse.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/network/WebSocketHandshakeResponse.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/text/StringOperators.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
7 years ago (2013-12-02 18:31:21 UTC) #1
eseidel
lgtm
7 years ago (2013-12-02 18:47:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/99733002/20001
7 years ago (2013-12-02 19:40:49 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 20:40:45 UTC) #4
Message was sent while issue was closed.
Change committed as 163027

Powered by Google App Engine
This is Rietveld 408576698