content/browser/renderer_host/render_widget_host_view_mac_unittest.mm - Issue 997283002: Coalesce async touch move events until the ack back from render

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

Issue 997283002: Coalesce async touch move events until the ack back from render (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing unittests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/touch_event_queue.cc ('K') | « content/browser/renderer_host/render_widget_host_view_aura_unittest.cc ('k') | content/common/input/input_event_ack.h » ('j') | content/common/input/input_event_ack.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

index 6fb79d187f3ea963ab6917fb8740e47f8690179c..2937ada6d405b41a8a6012c93cd5d912234d5144 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm

@@ -710,9 +710,8 @@ TEST_F(RenderWidgetHostViewMacTest, ScrollWheelEndEventDelivery) {

ASSERT_EQ(1U, process_host->sink().message_count());

// Send an ACK for the first wheel event, so that the queue will be flushed.

- InputHostMsg_HandleInputEvent_ACK_Params ack;

- ack.type = blink::WebInputEvent::MouseWheel;

- ack.state = INPUT_EVENT_ACK_STATE_CONSUMED;

+ InputEventAck ack(blink::WebInputEvent::MouseWheel,

+ INPUT_EVENT_ACK_STATE_CONSUMED);

scoped_ptr<IPC::Message> response(

new InputHostMsg_HandleInputEvent_ACK(0, ack));

host->OnMessageReceived(*response);

@@ -756,9 +755,8 @@ TEST_F(RenderWidgetHostViewMacTest, IgnoreEmptyUnhandledWheelEvent) {

process_host->sink().ClearMessages();

// Indicate that the wheel event was unhandled.

- InputHostMsg_HandleInputEvent_ACK_Params unhandled_ack;

- unhandled_ack.type = blink::WebInputEvent::MouseWheel;

- unhandled_ack.state = INPUT_EVENT_ACK_STATE_NOT_CONSUMED;

+ InputEventAck unhandled_ack(blink::WebInputEvent::MouseWheel,

+ INPUT_EVENT_ACK_STATE_NOT_CONSUMED);

scoped_ptr<IPC::Message> response1(

new InputHostMsg_HandleInputEvent_ACK(0, unhandled_ack));

host->OnMessageReceived(*response1);

@@ -883,9 +881,8 @@ TEST_F(RenderWidgetHostViewMacTest, PinchThresholding) {

RenderWidgetHostViewMac* view = new RenderWidgetHostViewMac(host, false);

// We'll use this IPC message to ack events.

- InputHostMsg_HandleInputEvent_ACK_Params ack;

- ack.type = blink::WebInputEvent::GesturePinchUpdate;

- ack.state = INPUT_EVENT_ACK_STATE_CONSUMED;

+ InputEventAck ack(blink::WebInputEvent::GesturePinchUpdate,

+ INPUT_EVENT_ACK_STATE_CONSUMED);

scoped_ptr<IPC::Message> response(

new InputHostMsg_HandleInputEvent_ACK(0, ack));