content/common/input/web_input_event_traits.cc - Issue 997283002: Coalesce async touch move events until the ack back from render

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/input/web_input_event_traits.cc

Issue 997283002: Coalesce async touch move events until the ack back from render (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/input/input_router_impl.cc ('K') | « content/browser/renderer_host/input/touch_event_queue.cc ('k') | content/renderer/input/input_event_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/input/web_input_event_traits.cc

diff --git a/content/common/input/web_input_event_traits.cc b/content/common/input/web_input_event_traits.cc

index 6ca962b5720d9741d2b6bc4d4d251f7e9a86b9ec..337a3620e67d6f42cc51b7e898ffee9e92f58a05 100644

--- a/content/common/input/web_input_event_traits.cc

+++ b/content/common/input/web_input_event_traits.cc

@@ -461,6 +461,8 @@ void WebInputEventTraits::Coalesce(const WebInputEvent& event_to_coalesce,

Apply(WebInputEventCoalesce(), event->type, event_to_coalesce, event);

}

+// For touchmove events, we always need an ACK back from render, and for async

+// touch move, we will also send a fake ACK.

bool WebInputEventTraits::IgnoresAckDisposition(const WebInputEvent& event) {

switch (event.type) {

case WebInputEvent::MouseDown:

@@ -479,7 +481,6 @@ bool WebInputEventTraits::IgnoresAckDisposition(const WebInputEvent& event) {

case WebInputEvent::TouchCancel:

return true;

case WebInputEvent::TouchStart:

- case WebInputEvent::TouchMove:

case WebInputEvent::TouchEnd:

return !static_cast<const WebTouchEvent&>(event).cancelable;

default: