Coalesce async touch move events until the ack back from render

content/common/input/web_input_event_traits.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/input/web_input_event_traits.h"
 
 #include <bitset>
 #include <limits>
 
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
+#include "content/common/input_messages.h"
 
 using base::StringAppendF;
 using base::SStringPrintf;
 using blink::WebGestureEvent;
 using blink::WebInputEvent;
 using blink::WebKeyboardEvent;
 using blink::WebMouseEvent;
 using blink::WebMouseWheelEvent;
 using blink::WebTouchEvent;
 using blink::WebTouchPoint;
@@ skipping 432 matching lines @@
                event_to_coalesce,
                &event);
 }
 
 void WebInputEventTraits::Coalesce(const WebInputEvent& event_to_coalesce,
                                    WebInputEvent* event) {
   DCHECK(event);
   Apply(WebInputEventCoalesce(), event->type, event_to_coalesce, event);
 }
 
-bool WebInputEventTraits::IgnoresAckDisposition(const WebInputEvent& event) {
+bool WebInputEventTraits::WillReceiveAckFromRenderer(
+    const WebInputEvent& event) {
   switch (event.type) {
     case WebInputEvent::MouseDown:
     case WebInputEvent::MouseUp:
     case WebInputEvent::MouseEnter:
     case WebInputEvent::MouseLeave:
     case WebInputEvent::ContextMenu:
     case WebInputEvent::GestureScrollBegin:
     case WebInputEvent::GestureScrollEnd:
     case WebInputEvent::GestureShowPress:
     case WebInputEvent::GestureTapUnconfirmed:
     case WebInputEvent::GestureTapDown:
     case WebInputEvent::GestureTapCancel:
     case WebInputEvent::GesturePinchBegin:
     case WebInputEvent::GesturePinchEnd:
     case WebInputEvent::TouchCancel:
+      return false;
+    case WebInputEvent::TouchStart:
+    case WebInputEvent::TouchEnd:
+      return static_cast<const WebTouchEvent&>(event).cancelable;
+    default:
       return true;
-    case WebInputEvent::TouchStart:
-    case WebInputEvent::TouchMove:
-    case WebInputEvent::TouchEnd:
-      return !static_cast<const WebTouchEvent&>(event).cancelable;
-    default:
-      return false;
   }
 }
 
+scoped_ptr<IPC::Message> WebInputEventTraits::CreateAckIfNecessary(
+    const blink::WebInputEvent& event,
+    const content::InputEventAckState ack_state,
+    const ui::LatencyInfo& latency_info,
+    scoped_ptr<DidOverscrollParams> overscroll_params,
+    int routing_id) {
+  scoped_ptr<IPC::Message> response;
+  if (event.type == WebInputEvent::TouchMove) {
+    const WebTouchEvent& touch = static_cast<const WebTouchEvent&>(event);
+    if (!touch.cancelable) {
+      response = scoped_ptr<IPC::Message>(

[jdduke (slow), 2015/04/15 17:14:53]

I think we can just do:

return make_scoped_ptr(new ...);

[lanwei, 2015/04/17 20:49:00]

Done.

+          new InputHostMsg_HandleUncancelableTouchMoveEvent_ACK(routing_id));
+      return response.Pass();
+    }
+  }
+
+  const bool send_ack = WebInputEventTraits::WillReceiveAckFromRenderer(event);
+  if (send_ack) {
+    DCHECK(!response);
+    InputHostMsg_HandleInputEvent_ACK_Params ack;
+    ack.type = event.type;
+    ack.state = ack_state;
+    ack.latency = latency_info;
+    ack.overscroll = overscroll_params.Pass();
+    response = scoped_ptr<IPC::Message>(

[jdduke (slow), 2015/04/15 17:14:53]

Same here, |return make_scoped_ptr(new ...)|.

[lanwei, 2015/04/17 20:49:00]

Done.

+        new InputHostMsg_HandleInputEvent_ACK(routing_id, ack));
+  }
+  return response.Pass();

[jdduke (slow), 2015/04/15 17:14:53]

Then this just becomes |return nullptr;|

[lanwei, 2015/04/17 20:49:00]

Done.

+}
+
 }  // namespace content