Issue 997273002: XFA: bound memcpy length in _png_load_bmp_attribute()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 997273002: XFA: bound memcpy length in _png_load_bmp_attribute() (Closed)

Created:
5 years, 9 months ago by Tom Sepez

Modified:
5 years, 9 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	core/src/fxcodec/codec/fx_codec_png.cpp	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

Lei, this fixes the suspicious code but doesn't address the key comparison issues.

5 years, 9 months ago (2015-03-11 21:34:28 UTC) #2

Tom Sepez

5 years, 9 months ago (2015-03-11 21:41:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e0557f60dd1a6130c481e3ab4f3787bf1125941a (presubmit successful).