Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issue 997193002: [Telemetry] Make chrome_tracing_agent state more resilient to tracing exception. (Closed)

Created:
5 years, 9 months ago by nednguyen
Modified:
5 years, 9 months ago
Reviewers:
Zhen Wang, sullivan, dtu, horo
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make chrome_tracing_agent state more resilient to tracing exception. Because ChromeTracingAgent class has global states, when any exception was raised inside StopTracing method, the active tracing state of this class is not set to False, making subsequent unittest that try to StartTracing fails because of this. Long term fix of this depends on crbug.com/317481 be fixed so that ChromeTracingAgent no longer have global state. BUG=459807 Committed: https://crrev.com/0f07fbef765278a5da7e21741eb2775419035a4a Cr-Commit-Position: refs/heads/master@{#320799}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M tools/telemetry/telemetry/core/platform/tracing_agent/chrome_tracing_agent.py View 3 chunks +20 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_agent/chrome_tracing_agent_unittest.py View 3 chunks +31 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/tracing_controller_unittest.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
nednguyen
5 years, 9 months ago (2015-03-13 17:19:32 UTC) #6
Zhen Wang
lg2m
5 years, 9 months ago (2015-03-13 21:53:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997193002/80001
5 years, 9 months ago (2015-03-14 01:14:40 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-14 01:14:43 UTC) #13
nednguyen
On 2015/03/14 01:14:43, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
5 years, 9 months ago (2015-03-16 17:42:51 UTC) #14
nednguyen
5 years, 9 months ago (2015-03-16 19:39:23 UTC) #16
sullivan
lgtm
5 years, 9 months ago (2015-03-16 20:31:06 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997193002/80001
5 years, 9 months ago (2015-03-16 20:31:52 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 9 months ago (2015-03-16 21:59:41 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 22:00:16 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f07fbef765278a5da7e21741eb2775419035a4a
Cr-Commit-Position: refs/heads/master@{#320799}

Powered by Google App Engine
This is Rietveld 408576698