[Extensions] Add a developerPrivate.updateExtensionConfiguration function

chrome/common/extensions/api/developer_private.idl

Index: chrome/common/extensions/api/developer_private.idl
diff --git a/chrome/common/extensions/api/developer_private.idl b/chrome/common/extensions/api/developer_private.idl
index d7e155598bfcfc08c477516f54f55b96c8a90833..76e9e727a783fb8f318518dfca6f7f038790d2c5 100644
--- a/chrome/common/extensions/api/developer_private.idl
+++ b/chrome/common/extensions/api/developer_private.idl
@@ -79,6 +79,14 @@ namespace developerPrivate {
     TERMINATED
   };
 
+  enum PermissionType {

[Devlin, 2015/03/16 21:35:16]

This is not my favorite name, because it's a bit of a stretch for error
collection and show action button (though both can be argued to be
"permissions").  Open to suggestions.

[not at google - send to devlin, 2015/03/16 21:48:08]

I might as well reply to this comment for my API meta comment.

I would design this API differently. My issues with it so far:
- "permission" is an overloaded term. "configuration" is more natural to me.
- it doesn't allow setting more than one thing at once, and similarly,
- the pairing of type-with-new-value is awkward.

Proposal:

dictionary ExtensionConfigurationUpdate {
  boolean? fileAccess;
  boolean? incognitoAccess;
  boolean? errorCollection;
  boolean? runOnAllUrls;
  boolean? showActionButton;
};

...

static void updateExtensionConfiguration(
    ExtensionConfigurationUpdate update, VoidCallback callback);

...

JavaScript would look like:

chrome.developerPrivate.updateExtensionConfiguration({
  fileAccess: true,
  incognitoAccess: true
});

...

Yes - this introduces a tri-state boolean. Sort of. It's pretty standard though
- you omit a parameter and it isn't set. You provide it and it sets it to true
or false.

[Devlin, 2015/03/16 22:41:37]

I like it. I was thinking about having the ability to set multiple before, but
didn't originally lean to having a tri-state boolean, and didn't want the bulk
of having n number of pairs (because, in practice, we only really update one
field at a time).  But having tristates here is actually quite nice.  Good call.

Still don't love the name (ExtensionConfiguration doesn't quite fit, either -
it's more like "run options" or something) but it beats "permission" ;)

+    FILE_ACCESS,
+    INCOGNITO_ACCESS,
+    ERROR_COLLECTION,
+    RUN_ON_ALL_URLS,
+    SHOW_ACTION_BUTTON
+  };
+
   dictionary AccessModifier {
     boolean isEnabled;
     boolean isActive;
@@ -226,6 +234,12 @@ namespace developerPrivate {
     boolean incognito;
   };
 
+  dictionary SetPermissionProperties {
+    DOMString extensionId;
+    PermissionType permission;
+    boolean isActive;
+  };
+
   dictionary ReloadOptions {
     // If false, an alert dialog will show in the event of a reload error.
     // Defaults to false.
@@ -397,13 +411,6 @@ namespace developerPrivate {
     static void inspect(InspectOptions options,
                         optional VoidCallback callback);
 
-    // Enables / Disables file access for an extension.
-    // |extensionId| : The id of the extension to set file access for.
-    // |allow| : Whether or not to allow file access for the extension.
-    static void allowFileAccess(DOMString extensionId,
-                                boolean allow,
-                                optional VoidCallback callback);
-
     // Reloads a given extension.
     // |extensionId| : The id of the extension to reload.
     // |options| : Additional configuration parameters.
@@ -411,12 +418,10 @@ namespace developerPrivate {
                        optional ReloadOptions options,
                        optional VoidCallback callback);
 
-    // Allows / Disallows an extension to run in incognito mode.
-    // |extensionId| : The id of the extension.
-    // |allow| : Whether or not the extension should be allowed incognito.
-    static void allowIncognito(DOMString extensionId,
-                               boolean allow,
-                               optional VoidCallback callback);
+    // Sets a permission for an extension.
+    // |properties| : The properties to use for setting the permission.
+    static void setExtensionPermission(SetPermissionProperties properties,
+                                       optional VoidCallback callback);
 
     // Loads a user-selected unpacked item.
     // |options| : Additional configuration parameters.