Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 997183005: [Extensions] Add a developerPrivate.updateExtensionConfiguration function (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 2e5965897aab48a6344448647a78c06748bb3e7f..284351eef37e313a6be3236736771d24171d506e 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -316,7 +316,10 @@ cr.define('extensions', function() {
// The 'Show Browser Action' button.
row.setupColumn('.show-button', 'showButton', 'click', function(e) {
- chrome.send('extensionSettingsShowButton', [extension.id]);
+ chrome.developerPrivate.updateExtensionConfiguration({
+ extensionId: extension.id,
+ showActionButton: true
+ });
});
// The 'allow in incognito' checkbox.
@@ -332,7 +335,10 @@ cr.define('extensions', function() {
} else {
butterBar.hidden = true;
}
- chrome.developerPrivate.allowIncognito(extension.id, checked);
+ chrome.developerPrivate.updateExtensionConfiguration({
+ extensionId: extension.id,
+ incognitoAccess: e.target.checked
+ });
}.bind(this));
// The 'collect errors' checkbox. This should only be visible if the
@@ -340,8 +346,10 @@ cr.define('extensions', function() {
// |errorCollectionEnabled| property.
row.setupColumn('.error-collection-control input', 'dev-collectErrors',
'change', function(e) {
- chrome.send('extensionSettingsEnableErrorCollection',
- [extension.id, String(e.target.checked)]);
+ chrome.developerPrivate.updateExtensionConfiguration({
+ extensionId: extension.id,
+ errorCollection: e.target.checked
+ });
});
// The 'allow on all urls' checkbox. This should only be visible if
@@ -349,14 +357,19 @@ cr.define('extensions', function() {
// extensions should want all urls.
row.setupColumn('.all-urls-control input', 'allUrls', 'click',
function(e) {
- chrome.send('extensionSettingsAllowOnAllUrls',
- [extension.id, String(e.target.checked)]);
+ chrome.developerPrivate.updateExtensionConfiguration({
+ extensionId: extension.id,
+ runOnAllUrls: e.target.checked
+ });
});
// The 'allow file:// access' checkbox.
row.setupColumn('.file-access-control input', 'localUrls', 'click',
function(e) {
- chrome.developerPrivate.allowFileAccess(extension.id, e.target.checked);
+ chrome.developerPrivate.updateExtensionConfiguration({
+ extensionId: extension.id,
+ fileAccess: e.target.checked
+ });
});
// The 'Options' button or link, depending on its behaviour.

Powered by Google App Engine
This is Rietveld 408576698