Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 997183003: Proxy canvas instead of DrawFilter for Android DM (Closed)

Created:
5 years, 9 months ago by tomhudson
Modified:
5 years, 9 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Since SkDrawFilter has serious architectural issues and may be deprecated, use a proxy SkCanvas for the same end: in every draw call, inspect the paint, changing it to fit within the capabilities of the Android Java (HWUI) drawing API. Verified that this allows us to reenable all our ColorFilter tests. R=djsollen@google.com Committed: https://skia.googlesource.com/skia/+/97cd070442aaf5511c638a4586e0a7a75297e468

Patch Set 1 #

Patch Set 2 : Fix unintended extra patch #

Total comments: 1

Patch Set 3 : Remove typedef #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -40 lines) Patch
M dm/DMSrcSinkAndroid.cpp View 1 2 3 chunks +170 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tomhudson
PTAL
5 years, 9 months ago (2015-03-11 17:31:50 UTC) #1
djsollen
lgtm
5 years, 9 months ago (2015-03-11 19:01:14 UTC) #2
djsollen
https://codereview.chromium.org/997183003/diff/20001/dm/DMSrcSinkAndroid.cpp File dm/DMSrcSinkAndroid.cpp (right): https://codereview.chromium.org/997183003/diff/20001/dm/DMSrcSinkAndroid.cpp#newcode35 dm/DMSrcSinkAndroid.cpp:35: typedef SkTLazy<SkPaint> SkLazyPaint; don't see the need to typedef ...
5 years, 9 months ago (2015-03-11 19:02:27 UTC) #3
tomhudson
On 2015/03/11 19:02:27, djsollen wrote: > https://codereview.chromium.org/997183003/diff/20001/dm/DMSrcSinkAndroid.cpp#newcode35 > dm/DMSrcSinkAndroid.cpp:35: typedef SkTLazy<SkPaint> SkLazyPaint; > don't see ...
5 years, 9 months ago (2015-03-11 19:11:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997183003/40001
5 years, 9 months ago (2015-03-11 19:12:18 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:21:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/97cd070442aaf5511c638a4586e0a7a75297e468

Powered by Google App Engine
This is Rietveld 408576698