Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 997173003: Revert of Raster into an SkP before rendering a DisplayList. (Closed)

Created:
5 years, 9 months ago by adamk
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Raster into an SkP before rendering a DisplayList. (patchset #2 id:20001 of https://codereview.chromium.org/966443003/) Reason for revert: Fails several slimmingpaint layout tests on Linux Failures that look to be real bugs include: virtual/slimmingpaint/fast/table/border-collapsing/adjacent-row-groups-multi.html virtual/slimmingpaint/fast/text/emphasis.html Original issue's description: > Raster into an SkPicture before rendering a DisplayList. > > Rasterizing a display list is more than 2x slower than rasterizing in the existing architecture. This is due to recording more with a display list and we have no bounding hierarchy to cull content quickly. > > We can address this by creating an SkPicture from the list, with a bounding hierarchy, and rasterizing that instead. The result is slightly faster than the non-S.P. pipeline but uses 2x more memory. > > BUG=464738 > > Committed: https://crrev.com/de765f47e9449420e46d968ec40bb6f41a193990 > Cr-Commit-Position: refs/heads/master@{#319519} > > Committed: https://crrev.com/c54bea7972a4a26fe49fd43a07cc99bb3a0e1990 > Cr-Commit-Position: refs/heads/master@{#320097} TBR=ajuma@chromium.org,enne@chromium.org,schenney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464738 Committed: https://crrev.com/ad1208d86feca0326497d0085b5950cfa8f8ca2c Cr-Commit-Position: refs/heads/master@{#320129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -55 lines) Patch
M cc/resources/display_item_list.h View 3 chunks +0 lines, -6 lines 0 comments Download
M cc/resources/display_item_list.cc View 3 chunks +5 lines, -46 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of Raster into an SkP before rendering a DisplayList.
5 years, 9 months ago (2015-03-11 18:48:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997173003/1
5 years, 9 months ago (2015-03-11 19:38:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-11 19:50:55 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 19:52:16 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad1208d86feca0326497d0085b5950cfa8f8ca2c
Cr-Commit-Position: refs/heads/master@{#320129}

Powered by Google App Engine
This is Rietveld 408576698