GuestView: Use computed size if getBoundingClientRect() size is unavailable.

GuestView: Use computed size if getBoundingClientRect() size is unavailable.

BUG=470230
Committed: https://crrev.com/7da6a47d850f47cc29f2c3663d192d5e96d0651c
Cr-Commit-Position: refs/heads/master@{#322440}

[Fady Samuel, 2015-03-24 20:10:04]

fsamuel@chromium.org changed reviewers:
+ paulmeyer@chromium.org

[paulmeyer, 2015-03-24 20:57:00]

https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/guest_view_container.js (right):

https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/guest_view_container.js:160: var css =
window.getComputedStyle(this.element, null);
I think it would be useful to add a comment here about why both the bounding
rect and the computed style properties are needed here. Otherwise later on
someone might see this and think they can just remove one or the other.

[Fady Samuel, 2015-03-26 17:50:38]

PTAL

https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
File extensions/renderer/resources/guest_view/guest_view_container.js (right):

https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
extensions/renderer/resources/guest_view/guest_view_container.js:160: var css =
window.getComputedStyle(this.element, null);
On 2015/03/24 20:57:00, Paul Meyer wrote:
> I think it would be useful to add a comment here about why both the bounding
> rect and the computed style properties are needed here. Otherwise later on
> someone might see this and think they can just remove one or the other.

Done.

[paulmeyer, 2015-03-26 17:51:56]

On 2015/03/26 17:50:38, Fady Samuel wrote:
> PTAL
> 
>
https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
> File extensions/renderer/resources/guest_view/guest_view_container.js (right):
> 
>
https://codereview.chromium.org/997153004/diff/20001/extensions/renderer/reso...
> extensions/renderer/resources/guest_view/guest_view_container.js:160: var css
=
> window.getComputedStyle(this.element, null);
> On 2015/03/24 20:57:00, Paul Meyer wrote:
> > I think it would be useful to add a comment here about why both the bounding
> > rect and the computed style properties are needed here. Otherwise later on
> > someone might see this and think they can just remove one or the other.
> 
> Done.

LGTM!

[Fady Samuel, 2015-03-26 17:52:27]

The CQ bit was checked by fsamuel@chromium.org

[commit-bot: I haz the power, 2015-03-26 17:52:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997153004/40001

[commit-bot: I haz the power, 2015-03-26 19:02:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-26 19:02:55]

Patchset 3 (id:??) landed as
https://crrev.com/7da6a47d850f47cc29f2c3663d192d5e96d0651c
Cr-Commit-Position: refs/heads/master@{#322440}