Recommit Enable SRI only for same origin and CORS content

Recommit Enable SRI only for same origin and CORS content

This fixes a memory leak and recommits the original patch in
https://codereview.chromium.org/954233003. The memory leak was caused by
bailing out of executeScript early on a integrity check failure, but
*after* pushCurrentScript() had been called (without calling
popCurrentScript()). This left the element dangling on the current
script stack without ever being popped, hence the memory leak.

As a solution, rather than calling popCurrentScript() early, this just
moves the access control check (and thus the bail out) before the script
is pushed on the stack. Thus, if a bail out occurs, there's no leak
because it was never on the stack. This matches how other failures and
bail outs in executeScript work as well.

R=mkwst@chromium.org
BUG=438663
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191789

[jww, 2015-03-11 21:44:28]

Mike, the original CL for this had a memory leak. This fixes that issue, and the
only change from the original CL is in ScriptLoader.cpp. Can you check that
file, where I moved the Access Control check earlier so there's no memory leak
when we return early on SRI check failure.

[Mike West, 2015-03-12 17:33:34]

mkwst@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-03-12 17:33:34]

Thanks for updating the CL description. LGTM (again). :)

[jww, 2015-03-12 17:35:02]

The CQ bit was checked by jww@chromium.org

[commit-bot: I haz the power, 2015-03-12 17:35:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/997153003/1

[commit-bot: I haz the power, 2015-03-12 18:53:22]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191789