Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 997073004: Move inspector/InspectorNodeIds to dom/DOMNodeIds. (Closed)

Created:
5 years, 9 months ago by sadrul
Modified:
5 years, 8 months ago
Reviewers:
esprehn, caseq, dmazzoni, yurys
CC:
aandrey+blink_chromium.org, aboxhall, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, blink-reviews-style_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, dstockwell, eae+blinkwatch, Eric Willigers, eustas+blink_chromium.org, jchaffraix+rendering, je_julie(Not used), kozyatinskiy+blink_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, Mike Lawther (Google), nektarios, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rjwright, rwlbuis, sergeyv+blink_chromium.org, shans, sof, slimming-paint-reviews_chromium.org, Steve Block, Timothy Loh, yurys+blink_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move inspector/InspectorNodeIds to dom/DOMNodeIds. InspectNodeIds is used in non-inspector code too (e.g. /core/layout/compositing/, /modules/accessibility), and newer code (e.g. CompositorProxy) is also going to use it. So move it into dom/DOMNodeIds. BUG=436952 TBR=dmazzoni@chromium.org for //Source/modules/accessibility Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -129 lines) Patch
M Source/core/core.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/dom/DOMNodeIds.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/dom/DOMNodeIds.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 6 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/inspector/InspectorNodeIds.h View 1 chunk +0 lines, -21 lines 0 comments Download
D Source/core/inspector/InspectorNodeIds.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTraceEvents.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/GraphicsContextAnnotator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/accessibility/InspectorAccessibilityAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sadrul
Hi! As suggested in https://codereview.chromium.org/1024233002/, this moves InspectorNodeIds into dom/ as DOMNodeIds.
5 years, 9 months ago (2015-03-26 06:11:41 UTC) #2
yurys
Can you provide more details on how this map is going to be used in ...
5 years, 9 months ago (2015-03-26 08:11:28 UTC) #4
sadrul
On 2015/03/26 08:11:28, yurys wrote: > Can you provide more details on how this map ...
5 years, 9 months ago (2015-03-26 08:18:27 UTC) #5
esprehn
lgtm, can you mention what existing code uses it in the commit message too? yurys@ ...
5 years, 9 months ago (2015-03-26 08:21:45 UTC) #6
yurys
On 2015/03/26 08:18:27, sadrul wrote: > On 2015/03/26 08:11:28, yurys wrote: > > Can you ...
5 years, 9 months ago (2015-03-26 08:24:16 UTC) #7
yurys
On 2015/03/26 08:21:45, esprehn wrote: > lgtm, can you mention what existing code uses it ...
5 years, 9 months ago (2015-03-26 08:26:51 UTC) #8
sadrul
+dmazzoni@ for Source/modules/accessibility change. On 2015/03/26 08:26:51, yurys wrote: > On 2015/03/26 08:21:45, esprehn wrote: ...
5 years, 9 months ago (2015-03-26 09:07:06 UTC) #10
yurys
On 2015/03/26 09:07:06, sadrul wrote: > +dmazzoni@ for Source/modules/accessibility change. > > On 2015/03/26 08:26:51, ...
5 years, 9 months ago (2015-03-26 09:24:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997073004/1
5 years, 8 months ago (2015-03-27 16:15:07 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-03-27 17:42:11 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192692

Powered by Google App Engine
This is Rietveld 408576698