Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 997063003: Version 4.2.77.5 (cherry-pick) (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
rossberg
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.2
Target Ref:
refs/pending/branch-heads/4.2
Project:
v8
Visibility:
Public.

Description

Version 4.2.77.5 (cherry-pick) Merged 1604bd46bf7fe0a8f7cd7780174030e26b93ab37 Implement subclassing Arrays. BUG=v8:3930, chromium:463894 LOG=N R=rossberg@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/2c4e3f811134b4422e9e7473b7087aad256ef84a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -21 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +19 lines, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +19 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +23 lines, -5 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +23 lines, -4 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +22 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 4 chunks +36 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +23 lines, -1 line 0 comments Download
A test/mjsunit/harmony/classes-subclass-arrays.js View 1 chunk +150 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
5 years, 9 months ago (2015-03-11 10:27:21 UTC) #1
Dmitry Lomov (no reviews)
PTAL, this seems legit :)
5 years, 9 months ago (2015-03-11 10:27:56 UTC) #2
rossberg
LGTM (more rubber)
5 years, 9 months ago (2015-03-11 10:30:46 UTC) #3
Dmitry Lomov (no reviews)
5 years, 9 months ago (2015-03-11 10:36:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c4e3f811134b4422e9e7473b7087aad256ef84a.

Powered by Google App Engine
This is Rietveld 408576698