Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Issue 997033002: Set the font size in the keyboard overlay explicitly. (Closed)

Created:
5 years, 9 months ago by xdai1
Modified:
5 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set the font size in the keyboard overlay explicitly. This is a regression issue caused by https://codereview.chromium.org/786023002. After we imported text_default.css, a default font-size (75%) will be applied to body unless we explicitly set the font-size value. To restore the previous font-size, we set the font-size in body to 100%. BUG=465604 TEST=manually checked the keyboard overlay Committed: https://crrev.com/f34f6774dd1857d55cc6667c119635d6e9049204 Cr-Commit-Position: refs/heads/master@{#320109}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xdai1
xiyuan, could you help to review the CL, please? Thanks!
5 years, 9 months ago (2015-03-11 16:42:03 UTC) #3
xiyuan
lgtm
5 years, 9 months ago (2015-03-11 16:45:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/997033002/20001
5 years, 9 months ago (2015-03-11 16:47:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 9 months ago (2015-03-11 18:06:29 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 18:07:28 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f34f6774dd1857d55cc6667c119635d6e9049204
Cr-Commit-Position: refs/heads/master@{#320109}

Powered by Google App Engine
This is Rietveld 408576698