Issue 997003003: Version 4.2.77.5 (cherry-pick)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 997003003: Version 4.2.77.5 (cherry-pick) (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)

Modified:
5 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev, Paweł Hajdan Jr., ulan

Base URL:
https://chromium.googlesource.com/v8/v8.git@4.2

Target Ref:
refs/pending/branch-heads/4.2

Project:
v8

Visibility:
Public.

Version 4.2.77.5 (cherry-pick) Merged 1604bd46bf7fe0a8f7cd7780174030e26b93ab37 Implement subclassing Arrays. BUG=v8:3930, chromium:463894 LOG=N R=rossberg@chromium.org

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+167 lines, -21 lines)			Patch
M	include/v8-version.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 chunk	+19 lines, -1 line	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	2 chunks	+19 lines, -4 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+23 lines, -5 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	2 chunks	+23 lines, -4 lines	0 comments	Download
M	src/mips64/code-stubs-mips64.cc	View	2 chunks	+22 lines, -3 lines	0 comments	Download
M	src/runtime/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime/runtime-array.cc	View	4 chunks	+36 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+23 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Dmitry Lomov (no reviews)

5 years, 9 months ago (2015-03-11 10:30:17 UTC) #3

Message was sent while issue was closed.

On 2015/03/11 10:25:40, rossberg wrote:
> LGTM (rubber)

This one is bogus since it misses a test.