Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996973003: Revamp Autofill Wallet settings (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, browser-components-watch_chromium.org, arv+watch_chromium.org, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revamp Autofill Wallet settings this is round 1. It is a good intermediate state between what we have now and what's in the mocks. BUG=446698 Committed: https://crrev.com/2499b74015ee2d97674eb7f8a132e3ff0c3b0eb1 Cr-Commit-Position: refs/heads/master@{#320411}

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : comment #

Patch Set 5 : mac compiles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -87 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.css View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.html View 2 chunks +9 lines, -18 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 2 chunks +22 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/autofill_options_list.js View 1 2 8 chunks +36 lines, -23 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 2 7 chunks +38 lines, -21 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_profile.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M components/autofill/core/browser/personal_data_manager_mac.mm View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Evan Stade
live mock is here: https://show.googleplex.com/zi-settings-desktop/
5 years, 9 months ago (2015-03-12 00:33:42 UTC) #2
please use gerrit instead
lgtm % nits. https://codereview.chromium.org/996973003/diff/40001/components/autofill/core/browser/autofill_profile.h File components/autofill/core/browser/autofill_profile.h (right): https://codereview.chromium.org/996973003/diff/40001/components/autofill/core/browser/autofill_profile.h#newcode38 components/autofill/core/browser/autofill_profile.h:38: // An auxiliary profile. nit: add ...
5 years, 9 months ago (2015-03-12 20:40:12 UTC) #3
Evan Stade
https://codereview.chromium.org/996973003/diff/40001/components/autofill/core/browser/autofill_profile.h File components/autofill/core/browser/autofill_profile.h (right): https://codereview.chromium.org/996973003/diff/40001/components/autofill/core/browser/autofill_profile.h#newcode38 components/autofill/core/browser/autofill_profile.h:38: // An auxiliary profile. On 2015/03/12 20:40:12, Rouslan Solomakhin ...
5 years, 9 months ago (2015-03-12 21:28:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996973003/60001
5 years, 9 months ago (2015-03-12 21:29:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996973003/80001
5 years, 9 months ago (2015-03-12 23:14:19 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-13 00:25:28 UTC) #11
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/2499b74015ee2d97674eb7f8a132e3ff0c3b0eb1 Cr-Commit-Position: refs/heads/master@{#320411}
5 years, 9 months ago (2015-03-13 00:25:59 UTC) #12
Dan Beam
5 years, 9 months ago (2015-03-16 23:11:40 UTC) #14
Message was sent while issue was closed. 
this commit introduced many closure errors:
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Lin...

Powered by Google App Engine
This is Rietveld 408576698