Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: services/dart/test/pingpong_target/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix regexes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/public/dart/src/handle.dart ('K') | « services/dart/test/pingpong/main.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/test/pingpong_target/main.dart
diff --git a/services/dart/test/pingpong_target/main.dart b/services/dart/test/pingpong_target/main.dart
index a91d04022112b579c4f05582826594c4785e18bd..8be497896fc8b453a1c8a4f93cb56802741dfe58 100644
--- a/services/dart/test/pingpong_target/main.dart
+++ b/services/dart/test/pingpong_target/main.dart
@@ -32,6 +32,13 @@ class PingPongServiceImpl implements PingPongService {
}
_stub.close();
}
+
+ Future pingTargetUrl(String url, int count, [Function responseFactory]) {}
+
+ Future pingTargetService(ProxyBase proxyBase, int count,
+ [Function responseFactory]) {}
+
+ getPingPongService(PingPongServiceStub serviceStub) {}
}
class PingPongApplication extends Application {
@@ -43,7 +50,12 @@ class PingPongApplication extends Application {
connection.provideService(PingPongServiceName,
(endpoint) => new PingPongServiceImpl(this, endpoint));
// Close the application when the first connection goes down.
- connection.onError = close;
+ connection.onError = closeApplication;
+ }
+
+ Future closeApplication() async {
+ await close();
+ assert(MojoHandle.reportLeakedHandles());
}
}
« mojo/public/dart/src/handle.dart ('K') | « services/dart/test/pingpong/main.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698