Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: services/dart/test/echo/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix regexes Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/dart/test/echo/main.dart
diff --git a/services/dart/test/echo/main.dart b/services/dart/test/echo/main.dart
index 91dd89b29b70ff42caf1d588fe79c1d66b97432a..30ea99c3763297304ffd88e72cf5c20b4192e952 100644
--- a/services/dart/test/echo/main.dart
+++ b/services/dart/test/echo/main.dart
@@ -17,7 +17,7 @@ class EchoServiceImpl implements EchoService {
_stub = new EchoServiceStub.fromEndpoint(endpoint, this);
}
- echoString(String value, Function responseFactory) {
+ echoString(String value, [Function responseFactory]) {
if (value == "quit") {
_stub.close();
}
@@ -39,5 +39,8 @@ class EchoApplication extends Application {
main(List args) {
MojoHandle appHandle = new MojoHandle(args[0]);
String url = args[1];
- new EchoApplication.fromHandle(appHandle);
+ new EchoApplication.fromHandle(appHandle)
+ ..onError = (() {
+ assert(MojoHandle.reportLeakedHandles());
+ });
}

Powered by Google App Engine
This is Rietveld 408576698