mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl - Issue 996923003: Dart: Better handle leak checks. close() is async.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Fix regexes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl

index 3903d822de04c8c6b20f6fe9a2d5046f2d08f30e..cca521d4e48342ca492307f6e20326a9f68f4660 100644

--- a/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/dart_templates/interface_definition.tmpl

@@ -154,7 +154,7 @@ class {{interface|name}}Proxy implements bindings.ProxyBase {

core.MojoMessagePipeEndpoint endpoint) =>

new {{interface|name}}Proxy.fromEndpoint(endpoint);

- void close() => impl.close();

+ Future close() => impl.close();

String toString() {

return "{{interface|name}}Proxy($impl)";

« mojo/public/dart/src/handle.dart ('K') | « mojo/public/dart/src/stub.dart ('k') | mojo/public/tools/dart_analyze.py » ('j') | no next file with comments »