Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: services/dart/test/echo/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/dart/dart_apptests/main.dart ('k') | services/dart/test/pingpong/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/dart/test/echo/main.dart
diff --git a/services/dart/test/echo/main.dart b/services/dart/test/echo/main.dart
index f02adae7ecfe439994721fbe4b7a1da9b8ad3a97..5c68f3d2487727e05c8f225f13b5c2c574332656 100644
--- a/services/dart/test/echo/main.dart
+++ b/services/dart/test/echo/main.dart
@@ -17,7 +17,7 @@ class EchoServiceImpl implements EchoService {
_stub = new EchoServiceStub.fromEndpoint(endpoint, this);
}
- echoString(String value, [Function responseFactory = null]) {
+ echoString(String value, [Function responseFactory]) {
if (value == "quit") {
_stub.close();
}
@@ -39,5 +39,8 @@ class EchoApplication extends Application {
main(List args) {
MojoHandle appHandle = new MojoHandle(args[0]);
String url = args[1];
- new EchoApplication.fromHandle(appHandle);
+ new EchoApplication.fromHandle(appHandle)
+ ..onError = (() {
+ assert(MojoHandle.reportLeakedHandles());
+ });
}
« no previous file with comments | « services/dart/dart_apptests/main.dart ('k') | services/dart/test/pingpong/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698