Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: mojo/dart/embedder/test/validation_unittest.cc

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/dart/embedder/test/run_dart_tests.cc ('k') | mojo/dart/test/bindings_generation_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/dart/embedder/test/validation_unittest.cc
diff --git a/mojo/dart/embedder/test/validation_unittest.cc b/mojo/dart/embedder/test/validation_unittest.cc
index 176be4269c726427cb956499490ed7b46a01e6c3..53effb3d0ef7a9cce69cf74c4278a0e93bc66efb 100644
--- a/mojo/dart/embedder/test/validation_unittest.cc
+++ b/mojo/dart/embedder/test/validation_unittest.cc
@@ -61,25 +61,23 @@ static void RunTest(const std::string& test) {
PathService::Get(base::DIR_EXE, &package_root);
package_root = package_root.AppendASCII("gen");
- // All tests run with these arguments.
- const int kNumArgs = 3;
- const char* args[kNumArgs];
- args[0] = "--enable_asserts";
- args[1] = "--enable_type_checks";
- args[2] = "--error_on_bad_type";
-
char* error = NULL;
bool unhandled_exception = false;
DartControllerConfig config;
config.script = source;
+#if defined(DEBUG)
+ config.strict_compilation = true;
+#else
+ config.strict_compilation = false;
+#endif
config.script_uri = test;
config.package_root = package_root.AsUTF8Unsafe();
config.application_data = nullptr;
config.callbacks.exception =
base::Bind(&exceptionCallback, &unhandled_exception);
config.entropy = generateEntropy;
- config.arguments = args;
- config.arguments_count = kNumArgs;
+ config.arguments = nullptr;
+ config.arguments_count = 0;
config.handle = MOJO_HANDLE_INVALID;
config.compile_all = false;
config.error = &error;
« no previous file with comments | « mojo/dart/embedder/test/run_dart_tests.cc ('k') | mojo/dart/test/bindings_generation_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698