Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: examples/dart/hello_world/hello/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/dart/console_example/main.dart ('k') | examples/dart/hello_world/world/main.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: examples/dart/hello_world/hello/main.dart
diff --git a/examples/dart/hello_world/hello/main.dart b/examples/dart/hello_world/hello/main.dart
index 8397bb4be72436c8788940fccdfb14ba41fc82a5..4ff5e247f79848eee12ef636b5aeafbaa258570e 100644
--- a/examples/dart/hello_world/hello/main.dart
+++ b/examples/dart/hello_world/hello/main.dart
@@ -5,6 +5,7 @@
// To run this app:
// mojo_shell mojo:hello
+import 'dart:async';
import 'dart:mojo.application';
import 'dart:mojo.bindings';
import 'dart:mojo.core';
@@ -23,7 +24,12 @@ class Hello extends Application {
// app has a chance to come up. Instead, we wait to close this app until
// the "world" app comes up, does its print, and closes its end of the
// connection.
- c.onError = close;
+ c.onError = closeApplication;
+ }
+
+ Future closeApplication() async {
+ await close();
+ assert(MojoHandle.reportLeakedHandles());
}
}
« no previous file with comments | « examples/dart/console_example/main.dart ('k') | examples/dart/hello_world/world/main.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698