Dart: Better handle leak checks. close() is async.

mojo/dart/embedder/dart_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/sys_info.h"
 #include "crypto/random.h"
 #include "dart/runtime/include/dart_api.h"
 #include "dart/runtime/include/dart_native_api.h"
 #include "mojo/dart/embedder/builtin.h"
 #include "mojo/dart/embedder/dart_controller.h"
 #include "mojo/dart/embedder/isolate_data.h"
+#include "mojo/public/c/system/core.h"
 
 namespace mojo {
 namespace dart {
 
 extern const uint8_t* snapshot_buffer;
 
 const char* kDartScheme = "dart:";
 const char* kMojoScheme = "mojo:";
 const char* kAsyncLibURL = "dart:async";
 const char* kInternalLibURL = "dart:_internal";
@@ skipping 396 matching lines @@
 
 static void UnhandledExceptionCallback(Dart_Handle error) {
   Dart_Isolate isolate = Dart_CurrentIsolate();
   void* data = Dart_IsolateData(isolate);
   IsolateData* isolate_data = reinterpret_cast<IsolateData*>(data);
   if (!isolate_data->callbacks.exception.is_null()) {
     // TODO(zra): Instead of passing an error handle, it may make life easier
     // for clients if we pass any error string here instead.
     isolate_data->callbacks.exception.Run(error);
   }
+
+  // Close handles generated by the isolate.
+  std::set<int64_t>& handles = isolate_data->unclosed_handles;
+  for (auto it = handles.begin(); it != handles.end(); ++it) {
+    MojoClose(static_cast<MojoHandle>(*it));
+  }
+  handles.clear();
 }
 
 
 bool DartController::initialized_ = false;
 Dart_Isolate DartController::root_isolate_ = nullptr;
 bool DartController::strict_compilation_ = false;
 
 void DartController::InitVmIfNeeded(Dart_EntropySource entropy,
                                     const char** arguments,
                                     int arguments_count) {
@@ skipping 285 matching lines @@
 
   Dart_ExitScope();
   Dart_ShutdownIsolate();
   Dart_Cleanup();
   root_isolate_ = nullptr;
   initialized_ = false;
 }
 
 }  // namespace apps
 }  // namespace mojo