Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: services/dart/test/pingpong_target/main.dart

Issue 996923003: Dart: Better handle leak checks. close() is async. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Merge Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « services/dart/test/pingpong/main.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:async'; 5 import 'dart:async';
6 import 'dart:mojo.application'; 6 import 'dart:mojo.application';
7 import 'dart:mojo.bindings'; 7 import 'dart:mojo.bindings';
8 import 'dart:mojo.core'; 8 import 'dart:mojo.core';
9 9
10 import 'package:services/dart/test/pingpong_service.mojom.dart'; 10 import 'package:services/dart/test/pingpong_service.mojom.dart';
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 45
46 class PingPongApplication extends Application { 46 class PingPongApplication extends Application {
47 PingPongApplication.fromHandle(MojoHandle handle) : super.fromHandle(handle); 47 PingPongApplication.fromHandle(MojoHandle handle) : super.fromHandle(handle);
48 48
49 @override 49 @override
50 void acceptConnection(String requestorUrl, String resolvedUrl, 50 void acceptConnection(String requestorUrl, String resolvedUrl,
51 ApplicationConnection connection) { 51 ApplicationConnection connection) {
52 connection.provideService(PingPongServiceName, 52 connection.provideService(PingPongServiceName,
53 (endpoint) => new PingPongServiceImpl(this, endpoint)); 53 (endpoint) => new PingPongServiceImpl(this, endpoint));
54 // Close the application when the first connection goes down. 54 // Close the application when the first connection goes down.
55 connection.onError = close; 55 connection.onError = closeApplication;
56 }
57
58 Future closeApplication() async {
59 await close();
60 assert(MojoHandle.reportLeakedHandles());
56 } 61 }
57 } 62 }
58 63
59 main(List args) { 64 main(List args) {
60 MojoHandle appHandle = new MojoHandle(args[0]); 65 MojoHandle appHandle = new MojoHandle(args[0]);
61 String url = args[1]; 66 String url = args[1];
62 new PingPongApplication.fromHandle(appHandle); 67 new PingPongApplication.fromHandle(appHandle);
63 } 68 }
OLDNEW
« no previous file with comments | « services/dart/test/pingpong/main.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698