MIPS: CpuProfiler: fix for CollectDeoptEvents test.

MIPS: CpuProfiler: fix for CollectDeoptEvents test.

Port a925f3f4784f8318f69a201a6b44aa94f97e4ba3

Original commit message:
The same idea as in https://codereview.chromium.org/984893003/

BUG=chromium:452067
LOG=n

Committed: https://crrev.com/ee4f1bd81d2cc5847111ac5dcb4a18a830359bcb
Cr-Commit-Position: refs/heads/master@{#27133}

[balazs.kilvady, 2015-03-10 19:20:39]

balazs.kilvady@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com, danno@chromium.org, dusan.milosavljevic@imgtec.com,
gergely.kis@imgtec.com, loislo@chromium.org, paul.lind@imgtec.com

[loislo, 2015-03-10 19:32:42]

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
src/mips/lithium-codegen-mips.cc:365: __ push(at);
Would it be more effective to move ra from upper MultiPush to here?

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
src/mips/lithium-codegen-mips.cc:380: __ Call(entry_offset);
there should be a Branch otherwise we will have two frames instead of one.

[balazs.kilvady, 2015-03-11 12:03:50]

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
src/mips/lithium-codegen-mips.cc:365: __ push(at);
On 2015/03/10 19:32:41, loislo wrote:
> Would it be more effective to move ra from upper MultiPush to here?

ra must be saved before the Call() as Call() overrides ra. The upper MultiPush()
is the exact port of arm PushFixedFrame().

https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
src/mips/lithium-codegen-mips.cc:380: __ Call(entry_offset);
On 2015/03/10 19:32:41, loislo wrote:
> there should be a Branch otherwise we will have two frames instead of one.

Thank you for catching this. Fix is Done.

[loislo, 2015-03-11 12:34:45]

On 2015/03/11 12:03:50, balazs.kilvady wrote:
>
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
> File src/mips/lithium-codegen-mips.cc (right):
> 
>
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
> src/mips/lithium-codegen-mips.cc:365: __ push(at);
> On 2015/03/10 19:32:41, loislo wrote:
> > Would it be more effective to move ra from upper MultiPush to here?
> 
> ra must be saved before the Call() as Call() overrides ra. The upper
MultiPush()
> is the exact port of arm PushFixedFrame().
> 
>
https://codereview.chromium.org/996883002/diff/1/src/mips/lithium-codegen-mip...
> src/mips/lithium-codegen-mips.cc:380: __ Call(entry_offset);
> On 2015/03/10 19:32:41, loislo wrote:
> > there should be a Branch otherwise we will have two frames instead of one.
> 
> Thank you for catching this. Fix is Done.

lgtm from my side.

[balazs.kilvady, 2015-03-11 13:07:03]

The CQ bit was checked by balazs.kilvady@imgtec.com

[commit-bot: I haz the power, 2015-03-11 13:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/996883002/40001

[commit-bot: I haz the power, 2015-03-11 13:42:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-11 13:42:59]

Patchset 3 (id:??) landed as
https://crrev.com/ee4f1bd81d2cc5847111ac5dcb4a18a830359bcb
Cr-Commit-Position: refs/heads/master@{#27133}