Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 996843002: Add profiling to WebContentsImpl::OnDidStopLoading. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add profiling to WebContentsImpl::OnDidStopLoading. BUG=465796 Committed: https://crrev.com/35629cc035f6758171f37bdc470b164decc07634 Cr-Commit-Position: refs/heads/master@{#319962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 5 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
erikchen
avi: Please review.
5 years, 9 months ago (2015-03-10 18:25:55 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-10 19:27:13 UTC) #3
Avi (use Gerrit)
lgtm lgtm
5 years, 9 months ago (2015-03-10 19:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996843002/1
5 years, 9 months ago (2015-03-10 19:33:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 20:43:33 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/35629cc035f6758171f37bdc470b164decc07634 Cr-Commit-Position: refs/heads/master@{#319962}
5 years, 9 months ago (2015-03-10 20:44:22 UTC) #8
Charlie Reis
5 years, 9 months ago (2015-03-10 23:15:33 UTC) #10
Message was sent while issue was closed. 
This CL is likely to interfere with the major changes that fdegans@ is making to
Did{Start,Stop}Loading:
https://codereview.chromium.org/989473003/

erikchen@: Can you coordinate with fdegans@ about what you need and how it might
fit into the new model?

Powered by Google App Engine
This is Rietveld 408576698