Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java

Issue 99683006: [Android WebView] Only send extra headers for the main page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Moved reloadSync into AwTestBase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java b/content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
index ba9619377f41b20f520741413c33d21838950125..932696994c1395a74acd6f310d17f81951223098 100644
--- a/content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
+++ b/content/public/android/java/src/org/chromium/content/browser/LoadUrlParams.java
@@ -219,17 +219,32 @@ public class LoadUrlParams {
* NavigationController::LoadUrlParams::extra_headers.
*/
String getExtraHeadersString() {
+ return getExtraHeadersString("\n", false);
+ }
+
+ /**
+ * Return the extra headers as a single String separated by "\r\n", or null if no extra header
+ * is set. This form is suitable for passing to native
+ * net::HttpRequestHeaders::AddHeadersFromString.
+ */
+ public String getExtraHttpRequestHeadersString() {
+ return getExtraHeadersString("\r\n", true);
+ }
+
+ private String getExtraHeadersString(String delimiter, boolean addTerminator) {
if (mExtraHeaders == null) return null;
StringBuilder headerBuilder = new StringBuilder();
for (Map.Entry<String, String> header : mExtraHeaders.entrySet()) {
- if (headerBuilder.length() > 0) headerBuilder.append("\n");
+ if (headerBuilder.length() > 0) headerBuilder.append("\r\n");
benm (inactive) 2013/12/09 17:49:11 should this be |delimiter|?
mnaganov (inactive) 2013/12/10 11:03:31 Sure, great catch! Fixed.
// Header name should be lower case.
headerBuilder.append(header.getKey().toLowerCase());
headerBuilder.append(":");
headerBuilder.append(header.getValue());
}
+ if (addTerminator)
+ headerBuilder.append(delimiter);
return headerBuilder.toString();
}

Powered by Google App Engine
This is Rietveld 408576698