content/public/browser/push_messaging_service.h - Issue 996813002: Deflake PushMessagingBrowserTest.DenyPushPermissionUnregisters & friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/push_messaging_service.h

Issue 996813002: Deflake PushMessagingBrowserTest.DenyPushPermissionUnregisters & friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Total rewrite: use callbacks to guarantee termination Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/push_messaging/push_messaging_service_impl.cc ('K') | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | content/public/browser/push_messaging_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/push_messaging_service.h

diff --git a/content/public/browser/push_messaging_service.h b/content/public/browser/push_messaging_service.h

index d9a51d4ec68c841017016b4f54fbf16bd6cd4d5e..8464e5c774f9725503a75c94bc28ae7d85e5749c 100644

--- a/content/public/browser/push_messaging_service.h

+++ b/content/public/browser/push_messaging_service.h

@@ -7,7 +7,7 @@

#include <string>

-#include "base/callback.h"

+#include "base/callback_forward.h"

#include "content/common/content_export.h"

#include "content/public/common/push_messaging_status.h"

#include "third_party/WebKit/public/platform/modules/push_messaging/WebPushPermissionStatus.h"

@@ -99,7 +99,8 @@ class CONTENT_EXPORT PushMessagingService {

// |service_worker_registration_id| for the given |origin|.

static void ClearPushRegistrationID(BrowserContext* browser_context,

const GURL& origin,

- int64 service_worker_registration_id);

+ int64 service_worker_registration_id,

+ const base::Closure& callback);

};

} // namespace content