chrome/browser/push_messaging/push_messaging_service_impl.h - Issue 996813002: Deflake PushMessagingBrowserTest.DenyPushPermissionUnregisters & friends

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 996813002: Deflake PushMessagingBrowserTest.DenyPushPermissionUnregisters & friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix app id lifetime, and simplify usage Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/push_messaging/push_messaging_service_impl.h

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h

index ed06b08366570d0250a3c5cb567b6943c11d27d2..5e462ceac2d8d3c1a7d5c56054a9ff1b6ad61d83 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.h

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h

@@ -89,6 +89,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

void Shutdown() override;

private:

+ friend class PushMessagingBrowserTest;

// A registration is pending until it has succeeded or failed.

void IncreasePushRegistrationCount(int add, bool is_pending);

void DecreasePushRegistrationCount(int subtract, bool was_pending);

« chrome/browser/push_messaging/push_messaging_browsertest.cc ('K') | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | no next file » | no next file with comments »