Issue 9968008: Fix ARM simulator build on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9968008: Fix ARM simulator build on Windows. (Closed)

Created:
8 years, 8 months ago by fschneider

Modified:
7 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix ARM simulator build on Windows. Visual Studio complained about loss of precision when converting uint64_t to unsigned int and about unary minus of unsigned values.

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	src/arm/assembler-arm.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
	M	src/arm/assembler-arm.cc	View		4 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM, nevertheless I think that all the old-skool bit fiddling and casting should really be ...

8 years, 8 months ago (2012-04-10 09:24:50 UTC) #2

Sven Panne

This fix is implicitly contained in https://codereview.chromium.org/12391055/, closing...

7 years, 9 months ago (2013-03-04 12:35:48 UTC) #3

fschneider

7 years, 9 months ago (2013-03-11 09:15:27 UTC) #4

Message was sent while issue was closed.

On 2013/03/04 12:35:48, Sven Panne wrote:
> This fix is implicitly contained in https://codereview.chromium.org/12391055/,
> closing...

Oh thanks for closing. I seem to have forgotten about this one.

Expand Messages | Collapse Messages