include/core/SkLazyPtr.h - Issue 996763002: Clean up SkDynamicAnnotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkLazyPtr.h

Issue 996763002: Clean up SkDynamicAnnotations. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: review Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkLazyPtr.h

diff --git a/include/core/SkLazyPtr.h b/include/core/SkLazyPtr.h

index fb2e43e874681c1e993992ae891bae40561930a4..035a269addbd162562d0c62ea195b333e4ece583 100644

--- a/include/core/SkLazyPtr.h

+++ b/include/core/SkLazyPtr.h

@@ -103,7 +103,7 @@ template <typename T> void sk_delete(T* ptr) { SkDELETE(ptr); }

template <typename T>

T consume_load(T* ptr) {

-#if DYNAMIC_ANNOTATIONS_ENABLED

+#if defined(THREAD_SANITIZER)

// TSAN gets anxious if we don't tell it what we're actually doing, a consume load.

return sk_atomic_load(ptr, sk_memory_order_consume);

#else

« no previous file with comments | « include/core/SkDynamicAnnotations.h ('k') | include/core/SkOnce.h » ('j') | no next file with comments »