Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 99673002: Add OWNER file in components/nacl/renderer (Closed)

Created:
7 years ago by darktears
Modified:
7 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add OWNER file in components/nacl/renderer The code in this directory was moved from chrome/renderer/pepper so the OWNERS over there are the appropriate folks to review the changes in the new nacl/renderer directory. This is part of an effort to componentize NaCl code. BUG=244791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238404

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + components/nacl/renderer/OWNERS View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
darktears
Mark : What do you think?
7 years ago (2013-12-02 18:14:32 UTC) #1
Mark Seaborn
On 2013/12/02 18:14:32, darktears wrote: > Mark : What do you think? Since this is ...
7 years ago (2013-12-02 22:44:53 UTC) #2
dmichael (off chromium)
One small change, o/w lgtm https://codereview.chromium.org/99673002/diff/1/components/nacl/renderer/OWNERS File components/nacl/renderer/OWNERS (right): https://codereview.chromium.org/99673002/diff/1/components/nacl/renderer/OWNERS#newcode2 components/nacl/renderer/OWNERS:2: brettw@chromium.org We should remove ...
7 years ago (2013-12-02 23:05:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/99673002/20001
7 years ago (2013-12-03 11:47:46 UTC) #4
commit-bot: I haz the power
7 years ago (2013-12-03 15:47:50 UTC) #5
Message was sent while issue was closed.
Change committed as 238404

Powered by Google App Engine
This is Rietveld 408576698