sdk/lib/io/platform_impl.dart - Issue 996683002: Fix warnings and hints in the SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/platform_impl.dart

Issue 996683002: Fix warnings and hints in the SDK (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Take suggestions from sgjesse Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/io/platform_impl.dart

diff --git a/sdk/lib/io/platform_impl.dart b/sdk/lib/io/platform_impl.dart

index d735521904ece9e850111c23fa695245ba284439..5ff41c40ebba314619676e9643b56c2a731a2589 100644

--- a/sdk/lib/io/platform_impl.dart

+++ b/sdk/lib/io/platform_impl.dart

@@ -112,7 +112,7 @@ class _CaseInsensitiveStringMap<V> implements Map<String, V> {

_map[key.toUpperCase()] = value;

}

V putIfAbsent(String key, V ifAbsent()) {

- _map.putIfAbsent(key.toUpperCase(), ifAbsent);

+ return _map.putIfAbsent(key.toUpperCase(), ifAbsent);

}

addAll(Map other) {

other.forEach((key, value) => this[key.toUpperCase()] = value);

« no previous file with comments | « sdk/lib/io/http_parser.dart ('k') | sdk/lib/typed_data/typed_data.dart » ('j') | no next file with comments »