Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 996663002: In PrintCode, keep the debug_name string alive for all uses. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In PrintCode, keep the debug_name string alive for all uses. BUG=chromium:465645 LOG=n R=titzer@chromium.org Committed: https://crrev.com/00f435040387653f7d539e4d44e278c21b5266e5 Cr-Commit-Position: refs/heads/master@{#27099}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/codegen.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-10 11:41:19 UTC) #1
titzer
lgtm
5 years, 9 months ago (2015-03-10 11:41:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996663002/1
5 years, 9 months ago (2015-03-10 11:47:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 12:02:48 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 12:03:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00f435040387653f7d539e4d44e278c21b5266e5
Cr-Commit-Position: refs/heads/master@{#27099}

Powered by Google App Engine
This is Rietveld 408576698