Source/core/rendering/svg/RenderSVGRoot.cpp - Issue 99663004: Avoid layout/full-repaint on view height change if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/RenderSVGRoot.cpp

Issue 99663004: Avoid layout/full-repaint on view height change if possible (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Protect the feature with a runtime flag Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/RenderSVGRoot.cpp

diff --git a/Source/core/rendering/svg/RenderSVGRoot.cpp b/Source/core/rendering/svg/RenderSVGRoot.cpp

index a4355cd4d9a64fa26624811b990ef5e4b1af31da..fc6bb767ebb4e509841ace9c67c613bb36e74720 100644

--- a/Source/core/rendering/svg/RenderSVGRoot.cpp

+++ b/Source/core/rendering/svg/RenderSVGRoot.cpp

@@ -173,10 +173,9 @@ LayoutUnit RenderSVGRoot::computeReplacedLogicalHeight() const

if (height.isPercent()) {

RenderBlock* cb = containingBlock();

ASSERT(cb);

- while (cb->isAnonymous()) {

+ while (cb->isAnonymous())

cb = cb->containingBlock();

- cb->addPercentHeightDescendant(const_cast<RenderSVGRoot*>(this));

- }

+ cb->addPercentHeightDescendant(const_cast<RenderSVGRoot*>(this));

ojan 2013/12/18 00:48:20 Ditto the other comment. Don't see why this is cor

} else

RenderBlock::removePercentHeightDescendant(const_cast<RenderSVGRoot*>(this));