Avoid layout/full-repaint on view height change if possible

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 85 matching lines @@
 using WebCore::FloatRect;
 using WebCore::HitTestRequest;
 using WebCore::Range;
 using blink::URLTestHelpers::toKURL;
 using blink::FrameTestHelpers::runPendingTasks;
 
 namespace {
 
 const int touchPointPadding = 32;
 
 #define EXPECT_EQ_RECT(a, b) \

[ojan, 2014/01/03 21:19:01]

Does this really need to be a macro? Can't this just be a static function?

[Xianzhu, 2014/01/03 22:11:53]

Being a macro it'll output correct line number when EXPECT_EQ fails.

-    EXPECT_EQ(a.x(), b.x()); \
-    EXPECT_EQ(a.y(), b.y()); \
-    EXPECT_EQ(a.width(), b.width()); \
-    EXPECT_EQ(a.height(), b.height());
+    do { \
+        EXPECT_EQ(a.x(), b.x()); \
+        EXPECT_EQ(a.y(), b.y()); \
+        EXPECT_EQ(a.width(), b.width()); \
+        EXPECT_EQ(a.height(), b.height()); \
+    } while (false)
 
 class FakeCompositingWebViewClient : public WebViewClient {
 public:
     virtual ~FakeCompositingWebViewClient()
     {
     }
 
     virtual void initializeLayerTreeView() OVERRIDE
     {
         m_layerTreeView = adoptPtr(Platform::current()->unitTestSupport()->createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest));
@@ skipping 4811 matching lines @@
     EXPECT_TRUE(frame->currentHistoryItem().isNull());
 
     Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
 
     // After commit, there is.
     WebHistoryItem item = frame->currentHistoryItem();
     ASSERT_FALSE(item.isNull());
     EXPECT_EQ(url, item.urlString().utf8());
 }
 
+TEST_F(WebFrameTest, heightChangeRepaint)
+{
+    const char* kTests[] = {
+        "repaint/height-change-no-full-repaint1.html",
+        "repaint/height-change-no-full-repaint2.html",
+
+        // The following tests need full repaint on height change for now,
+        // but may be optimized not to need full repaint in the future and need
+        // to be updated.
+        "repaint/height-change-repaint1.html", // vertical writing mode
+        "repaint/height-change-repaint2.html", // frameset
+        "repaint/height-change-repaint3.html", // percentage height
+        "repaint/height-change-repaint4.html", // positioned percentage height
+        "repaint/height-change-repaint5.html", // percentage top
+        "repaint/height-change-repaint6.html", // bottom
+        "repaint/height-change-repaint7.html", // viewport related media query
+        "repaint/height-change-repaint8.html", // viewport percentage length
+    };
+
+    UseMockScrollbarSettings mockScrollbarSettings;
+
+    FrameTestHelpers::WebViewHelper webViewHelper;
+    WebViewImpl* webView = webViewHelper.initialize(true);
+
+    for (size_t i = 0; i < arraysize(kTests); ++i) {
+        SCOPED_TRACE(kTests[i]);
+        registerMockedHttpURLLoad(kTests[i]);
+        FrameTestHelpers::loadFrame(webView->mainFrame(), m_baseURL + kTests[i]);
+        Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();
+
+        webView->resize(WebSize(200, 200));
+        webView->layout();
+
+        // Change height.
+        WebCore::FrameView* frameView = webView->mainFrameImpl()->frameView();
+        frameView->setTracksRepaints(true);
+        webView->resize(WebSize(200, 300));
+        webView->layout();
+        if (strstr(kTests[i], "no-full-repaint"))
+            EXPECT_EQ_RECT(WebCore::IntRect(0, 200, 200, 100), WebCore::unionRect(frameView->trackedRepaintRects()));
+        else
+            EXPECT_EQ_RECT(WebCore::IntRect(0, 0, 200, 300), WebCore::unionRect(frameView->trackedRepaintRects()));
+        frameView->setTracksRepaints(false);
+
+        // Change width, ensure optimized logic for height change doesn't break repaint on width change.
+        frameView->setTracksRepaints(true);
+        webView->resize(WebSize(300, 300));
+        webView->layout();
+        EXPECT_EQ_RECT(WebCore::IntRect(0, 0, 300, 300), WebCore::unionRect(frameView->trackedRepaintRects()));
+        frameView->setTracksRepaints(false);
+    }
+}
+
 } // namespace