Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 996613002: Update AffiliationFetcher to use new wire format. (Closed)

Created:
5 years, 9 months ago by engedy
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update AffiliationFetcher to use new Affiliation API wire format. The new format is not backward compatible with the old one, therefore this CL updates the client side protobuf definitions to be in line with the API definition. However, this CL does not yet make use of any additional fields introduced in the new wire format. BUG=437865 Committed: https://crrev.com/516abadc2553489ce28faeea4917280032fbe91d Cr-Commit-Position: refs/heads/master@{#319860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -23 lines) Patch
M components/password_manager/core/browser/affiliation_api.proto View 1 chunk +21 lines, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_fetcher_unittest.cc View 5 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
LGTM.
5 years, 9 months ago (2015-03-10 10:19:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996613002/1
5 years, 9 months ago (2015-03-10 10:20:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 11:24:34 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:25:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/516abadc2553489ce28faeea4917280032fbe91d
Cr-Commit-Position: refs/heads/master@{#319860}

Powered by Google App Engine
This is Rietveld 408576698