Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 996603003: Add [TypeChecking=Interface] to XSLTProcessor interface (Closed)

Created:
5 years, 9 months ago by Jens Widell
Modified:
5 years, 9 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add [TypeChecking=Interface] to XSLTProcessor interface Also make affected arguments (to importNode() and transformTo*()) non- optional, like in Firefox. It makes no sense to call either function without any of the arguments, and the previous behavior was to fail silently in that case. Also make the return type of transformTo*() nullable to reflect how they are actually implemented; they currently return null on failure. BUG=462561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191639

Patch Set 1 #

Patch Set 2 : update test #

Patch Set 3 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M LayoutTests/fast/xsl/xslt-processor.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/xsl/xslt-processor-expected.txt View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/XSLTProcessor.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/xml/XSLTProcessor.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/xml/XSLTProcessor.idl View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jens Widell
PTAL
5 years, 9 months ago (2015-03-10 10:11:55 UTC) #2
philipj_slow
lgtm
5 years, 9 months ago (2015-03-10 12:10:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996603003/1
5 years, 9 months ago (2015-03-10 12:10:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996603003/40001
5 years, 9 months ago (2015-03-10 15:07:06 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 17:11:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191639

Powered by Google App Engine
This is Rietveld 408576698