Catch printf() in CheckSpamLogging

PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Chromium.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
@@ skipping 831 matching lines @@
   source_file_filter = lambda x: input_api.FilterSourceFile(
       x, white_list=(file_inclusion_pattern,), black_list=black_list)
 
   log_info = []
   printf = []
 
   for f in input_api.AffectedSourceFiles(source_file_filter):
     contents = input_api.ReadFile(f, 'rb')
     if re.search(r"\bD?LOG\s*\(\s*INFO\s*\)", contents):
       log_info.append(f.LocalPath())
     if re.search(r"\bD?LOG_IF\s*\(\s*INFO\s*,", contents):

[M-A Ruel, 2013/12/02 21:06:09]

elif

[jln (very slow on Chromium), 2013/12/02 21:38:06]

Done.

       log_info.append(f.LocalPath())
-    if re.search(r"\bf?printf\((stdout|stderr)", contents):
+    if re.search(r"\bprintf\(", contents):

[M-A Ruel, 2013/12/02 21:06:09]

insert a line to make it clear they are not doing the same thing.

[jln (very slow on Chromium), 2013/12/02 21:38:06]

Done.

+      printf.append(f.LocalPath())
+    if re.search(r"\bfprintf\((stdout|stderr)", contents):

[M-A Ruel, 2013/12/02 21:06:09]

elif

[jln (very slow on Chromium), 2013/12/02 21:38:06]

Done.

       printf.append(f.LocalPath())
 
   if log_info:
     return [output_api.PresubmitError(
       'These files spam the console log with LOG(INFO):',
       items=log_info)]
   if printf:
     return [output_api.PresubmitError(
       'These files spam the console log with printf/fprintf:',
       items=printf)]
@@ skipping 270 matching lines @@
     trybots += ['cros_x86']
 
   # The AOSP bot doesn't build the chrome/ layer, so ignore any changes to it
   # unless they're .gyp(i) files as changes to those files can break the gyp
   # step on that bot.
   if (not all(re.search('^chrome', f) for f in files) or
       any(re.search('\.gypi?$', f) for f in files)):
     trybots += ['android_aosp']
 
   return trybots