| Index: source/libvpx/third_party/libyuv/source/mjpeg_validate.cc
|
| diff --git a/source/libvpx/third_party/libyuv/source/mjpeg_validate.cc b/source/libvpx/third_party/libyuv/source/mjpeg_validate.cc
|
| index 23d22d099bbeebd3f9b6b7263514d29c4180e6d9..40ce2f787a1a450fd70d932acaa34baf9ca1ed2a 100644
|
| --- a/source/libvpx/third_party/libyuv/source/mjpeg_validate.cc
|
| +++ b/source/libvpx/third_party/libyuv/source/mjpeg_validate.cc
|
| @@ -10,15 +10,66 @@
|
|
|
| #include "libyuv/mjpeg_decoder.h"
|
|
|
| +#include <string.h> // For memchr.
|
| +
|
| #ifdef __cplusplus
|
| namespace libyuv {
|
| extern "C" {
|
| #endif
|
|
|
| +// Enable this to try scasb implementation.
|
| +// #define ENABLE_SCASB 1
|
| +
|
| +#ifdef ENABLE_SCASB
|
| +
|
| +// Multiple of 1.
|
| +__declspec(naked) __declspec(align(16))
|
| +const uint8* ScanRow_ERMS(const uint8* src, uint32 val, int count) {
|
| + __asm {
|
| + mov edx, edi
|
| + mov edi, [esp + 4] // src
|
| + mov eax, [esp + 8] // val
|
| + mov ecx, [esp + 12] // count
|
| + repne scasb
|
| + jne sr99
|
| + mov eax, edi
|
| + sub eax, 1
|
| + mov edi, edx
|
| + ret
|
| +
|
| + sr99:
|
| + mov eax, 0
|
| + mov edi, edx
|
| + ret
|
| + }
|
| +}
|
| +#endif
|
| +
|
| +// Helper function to scan for EOI marker.
|
| +static LIBYUV_BOOL ScanEOI(const uint8* sample, size_t sample_size) {
|
| + const uint8* end = sample + sample_size - 1;
|
| + const uint8* it = sample;
|
| + for (;;) {
|
| +#ifdef ENABLE_SCASB
|
| + it = ScanRow_ERMS(it, 0xff, end - it);
|
| +#else
|
| + it = static_cast<const uint8*>(memchr(it, 0xff, end - it));
|
| +#endif
|
| + if (it == NULL) {
|
| + break;
|
| + }
|
| + if (it[1] == 0xd9) {
|
| + return LIBYUV_TRUE; // Success: Valid jpeg.
|
| + }
|
| + ++it; // Skip over current 0xff.
|
| + }
|
| + // ERROR: Invalid jpeg end code not found. Size sample_size
|
| + return LIBYUV_FALSE;
|
| +}
|
| +
|
| // Helper function to validate the jpeg appears intact.
|
| -// TODO(fbarchard): Optimize case where SOI is found but EOI is not.
|
| LIBYUV_BOOL ValidateJpeg(const uint8* sample, size_t sample_size) {
|
| - size_t i;
|
| + const size_t kBackSearchSize = 1024;
|
| if (sample_size < 64) {
|
| // ERROR: Invalid jpeg size: sample_size
|
| return LIBYUV_FALSE;
|
| @@ -27,17 +78,20 @@ LIBYUV_BOOL ValidateJpeg(const uint8* sample, size_t sample_size) {
|
| // ERROR: Invalid jpeg initial start code
|
| return LIBYUV_FALSE;
|
| }
|
| - for (i = sample_size - 2; i > 1;) {
|
| - if (sample[i] != 0xd9) {
|
| - if (sample[i] == 0xff && sample[i + 1] == 0xd9) { // End Of Image
|
| - return LIBYUV_TRUE; // Success: Valid jpeg.
|
| - }
|
| - --i;
|
| + // Step over SOI marker.
|
| + sample += 2;
|
| + sample_size -= 2;
|
| +
|
| + // Look for the End Of Image (EOI) marker in the end kilobyte of the buffer.
|
| + if (sample_size > kBackSearchSize) {
|
| + if (ScanEOI(sample + sample_size - kBackSearchSize, kBackSearchSize)) {
|
| + return LIBYUV_TRUE; // Success: Valid jpeg.
|
| }
|
| - --i;
|
| + // Reduce search size for forward search.
|
| + sample_size = sample_size - kBackSearchSize + 1;
|
| }
|
| - // ERROR: Invalid jpeg end code not found. Size sample_size
|
| - return LIBYUV_FALSE;
|
| + return ScanEOI(sample, sample_size);
|
| +
|
| }
|
|
|
| #ifdef __cplusplus
|
|
|