Deprecate chrome.extension.sendRequest in favor of sendMessage, with a safer

chrome/renderer/resources/extensions/extension_custom_bindings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Custom bindings for the extension API.
 
 var extensionNatives = requireNative('extension');
 var GetExtensionViews = extensionNatives.GetExtensionViews;
 var OpenChannelToExtension = extensionNatives.OpenChannelToExtension;
 
@@ skipping 34 matching lines @@
     return GetExtensionViews(windowId, 'TAB');
   });
 
   apiFunctions.setHandleRequest('getURL', function(path) {
     path = String(path);
     if (!path.length || path[0] != '/')
       path = '/' + path;
     return 'chrome-extension://' + extensionId + path;
   });
 
-  apiFunctions.setUpdateArgumentsPreValidate('sendRequest', function() {
+  function sendMessageUpdateArguments() {
     // Align missing (optional) function arguments with the arguments that
     // schema validation is expecting, e.g.
     //   extension.sendRequest(req)     -> extension.sendRequest(null, req)
     //   extension.sendRequest(req, cb) -> extension.sendRequest(null, req, cb)
     var lastArg = arguments.length - 1;
 
     // responseCallback (last argument) is optional.
     var responseCallback = null;
     if (typeof(arguments[lastArg]) == 'function')
       responseCallback = arguments[lastArg--];
 
     // request (second argument) is required.
     var request = arguments[lastArg--];
 
     // targetId (first argument, extensionId in the manfiest) is optional.
     var targetId = null;
     if (lastArg >= 0)
       targetId = arguments[lastArg--];
 
     if (lastArg != -1)
-      throw new Error('Invalid arguments to sendRequest.');
+      throw new Error('Invalid arguments to sendMessage.');
     return [targetId, request, responseCallback];
-  });
+  }
+  apiFunctions.setUpdateArgumentsPreValidate('sendRequest',
+                                             sendMessageUpdateArguments);

[Aaron Boodman, 2012/03/30 21:28:00]

You could use sendMessageUpdateArguments.bind(null, 'sendRequest') to pass in
the name for the error. You'd have to update the argument munging code slightly
inside the function.

[Matt Perry, 2012/03/30 23:02:48]

Done.

+  apiFunctions.setUpdateArgumentsPreValidate('sendMessage',
+                                             sendMessageUpdateArguments);
 
   apiFunctions.setHandleRequest('sendRequest',
                                 function(targetId, request, responseCallback) {
-    if (!targetId)
-      targetId = extensionId;
-    if (!responseCallback)
-      responseCallback = function() {};
+    var port = chrome.extension.connect(targetId || extensionId,
+                                        {name: chromeHidden.kRequestChannel});
+    chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
+  });
 
-    var connectInfo = { name: chromeHidden.kRequestChannel };
-    var port = chrome.extension.connect(targetId, connectInfo);
-
-    port.postMessage(request);
-    port.onDisconnect.addListener(function() {
-      // For onDisconnects, we only notify the callback if there was an error
-      try {
-        if (chrome.extension.lastError)
-          responseCallback();
-      } finally {
-        port = null;
-      }
-    });
-    port.onMessage.addListener(function(response) {
-      try {
-        responseCallback(response);
-      } finally {
-        port.disconnect();
-        port = null;
-      }
-    });
+  apiFunctions.setHandleRequest('sendMessage',
+                                function(targetId, message, responseCallback) {
+    var port = chrome.extension.connect(targetId || extensionId,
+                                        {name: chromeHidden.kMessageChannel});
+    chromeHidden.Port.sendMessageImpl(port, message, responseCallback);
   });
 
   apiFunctions.setUpdateArgumentsPreValidate('connect', function() {
     // Align missing (optional) function arguments with the arguments that
     // schema validation is expecting, e.g.
     //   extension.connect()   -> extension.connect(null, null)
     //   extension.connect({}) -> extension.connect(null, {})
     var nextArg = 0;
 
     // targetId (first argument) is optional.
@@ skipping 17 matching lines @@
     var name = '';
     if (connectInfo && connectInfo.name)
       name = connectInfo.name;
 
     var portId = OpenChannelToExtension(extensionId, targetId, name);
     if (portId >= 0)
       return chromeHidden.Port.createPort(portId, name);
     throw new Error('Error connecting to extension ' + targetId);
   });
 });