Deprecate chrome.extension.sendRequest in favor of sendMessage, with a safer

chrome/renderer/resources/extensions/event.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
   var eventBindingsNatives = requireNative('event_bindings');
   var AttachEvent = eventBindingsNatives.AttachEvent;
   var DetachEvent = eventBindingsNatives.DetachEvent;
   var Print = eventBindingsNatives.Print;
 
   var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
@@ skipping 97 matching lines @@
   // Dispatches a named event with the given JSON array, which is deserialized
   // before dispatch. The JSON array is the list of arguments that will be
   // sent with the event callback.
   chromeHidden.Event.dispatchJSON = function(name, args) {
     if (attachedNamedEvents[name]) {
       if (args) {
         args = chromeHidden.JSON.parse(args);
         if (eventArgumentMassagers[name])
           eventArgumentMassagers[name](args);
       }
-      return attachedNamedEvents[name].dispatch.apply(
+      var result = attachedNamedEvents[name].dispatch.apply(
           attachedNamedEvents[name], args);
+      if (result && result.validationErrors)
+        return result.validationErrors;
     }
   };
 
   // Dispatches a named event with the given arguments, supplied as an array.
   chromeHidden.Event.dispatch = function(name, args) {
     if (attachedNamedEvents[name]) {
       attachedNamedEvents[name].dispatch.apply(
           attachedNamedEvents[name], args);
     }
   };
@@ skipping 56 matching lines @@
   };
 
   // Dispatches this event object to all listeners, passing all supplied
   // arguments to this function each listener.
   chrome.Event.prototype.dispatch = function(varargs) {
     if (!this.eventOptions_.supportsListeners)
       throw new Error("This event does not support listeners.");
     var args = Array.prototype.slice.call(arguments);
     var validationErrors = this.validate_(args);
     if (validationErrors) {
-      return validationErrors;
+      return {validationErrors: validationErrors};
     }
+    var results = [];
     for (var i = 0; i < this.listeners_.length; i++) {
       try {
-        this.listeners_[i].apply(null, args);
+        var result = this.listeners_[i].apply(null, args);
+        if (result !== undefined)
+          results.push(result);
       } catch (e) {
         console.error("Error in event handler for '" + this.eventName_ +
                       "': " + e.stack);
       }
     }
+    if (results.length)
+      return {results: results};
   };
 
   // Attaches this event object to its name.  Only one object can have a given
   // name.
   chrome.Event.prototype.attach_ = function() {
     AttachEvent(this.eventName_);
     allAttachedEvents[allAttachedEvents.length] = this;
     if (!this.eventName_)
       return;
 
@@ skipping 86 matching lines @@
     for (var i = 0; i < allAttachedEvents.length; ++i) {
       var event = allAttachedEvents[i];
       if (event)
         event.detach_(false);
     }
   };
 
   chromeHidden.dispatchError = function(msg) {
     console.error(msg);
   };