Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 996483002: Improve code with early returns. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Daniel Bratell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve code with early returns. Improve SpdyHttpUtils::GetUrlFromHeaderBlock() implementation with early returns. Get rid of a number of temporary variables that were declared too far from where they were first used. Also remove SPDY2-specific code, as SPDY2 is no longer supported in Chromium. Acknowledgements to Daniel Bratell for suggesting to use append instead of inline operator+ that would create unnecessary temporary strings, see https://crrev.com/965773002. BUG= Committed: https://crrev.com/f5a07dab231907ba19ada492ac852b3a7037190c Cr-Commit-Position: refs/heads/master@{#319784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M net/spdy/spdy_http_utils.cc View 1 chunk +16 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bence
Ryan, PTAL. Thanks.
5 years, 9 months ago (2015-03-09 21:42:09 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-09 22:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/996483002/1
5 years, 9 months ago (2015-03-09 23:05:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 00:04:13 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 00:04:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5a07dab231907ba19ada492ac852b3a7037190c
Cr-Commit-Position: refs/heads/master@{#319784}

Powered by Google App Engine
This is Rietveld 408576698