Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: ui/compositor/compositor.cc

Issue 996453002: Allow ui::Compositor to disable commits during tab-switch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleaned up version Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/compositor/compositor.cc
diff --git a/ui/compositor/compositor.cc b/ui/compositor/compositor.cc
index 6293c2c19cf6d6e2fbb2fda6a548b18226e15cfa..65cfa220ce8a477bd99f4dfbe4315733c5e0cbf9 100644
--- a/ui/compositor/compositor.cc
+++ b/ui/compositor/compositor.cc
@@ -47,10 +47,12 @@ namespace ui {
CompositorLock::CompositorLock(Compositor* compositor)
: compositor_(compositor) {
- compositor_->task_runner_->PostDelayedTask(
- FROM_HERE,
- base::Bind(&CompositorLock::CancelLock, AsWeakPtr()),
- base::TimeDelta::FromMilliseconds(kCompositorLockTimeoutMs));
+ if (compositor_->locks_will_time_out_) {
+ compositor_->task_runner_->PostDelayedTask(
+ FROM_HERE,
+ base::Bind(&CompositorLock::CancelLock, AsWeakPtr()),
+ base::TimeDelta::FromMilliseconds(kCompositorLockTimeoutMs));
+ }
}
CompositorLock::~CompositorLock() {
@@ -76,7 +78,7 @@ Compositor::Compositor(gfx::AcceleratedWidget widget,
device_scale_factor_(0.0f),
last_started_frame_(0),
last_ended_frame_(0),
- disable_schedule_composite_(false),
+ locks_will_time_out_(true),
compositor_lock_(NULL),
layer_animator_collection_(this),
weak_ptr_factory_(this) {
@@ -294,12 +296,8 @@ void Compositor::BeginMainFrameNotExpectedSoon() {
}
void Compositor::Layout() {
- // We're sending damage that will be addressed during this composite
- // cycle, so we don't need to schedule another composite to address it.
- disable_schedule_composite_ = true;
if (root_layer_)
root_layer_->SendDamagedRects();
- disable_schedule_composite_ = false;
}
void Compositor::RequestNewOutputSurface() {

Powered by Google App Engine
This is Rietveld 408576698